Set VectorStore.search embedding argument type #2538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
There were some users that didn't know what should they be putting inside of embed_data parameter ins Vectorstore's search method. Intuitively most of them expect it to support direct strings. In the future we are also planning to add batch query support. So decided to add make embed_data parameter accept both string and List of strings.
Things to be aware of
Things to worry about
Additional Context