Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VectorStore.search embedding argument type #2538

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

adolkhan
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

There were some users that didn't know what should they be putting inside of embed_data parameter ins Vectorstore's search method. Intuitively most of them expect it to support direct strings. In the future we are also planning to add batch query support. So decided to add make embed_data parameter accept both string and List of strings.

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 36.36% and project coverage change: -0.02% ⚠️

Comparison is base (8749a4d) 84.92% compared to head (4d7bfa8) 84.90%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2538      +/-   ##
==========================================
- Coverage   84.92%   84.90%   -0.02%     
==========================================
  Files         328      328              
  Lines       39035    39043       +8     
==========================================
  Hits        33149    33149              
- Misses       5886     5894       +8     
Flag Coverage Δ
unittests 84.90% <36.36%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/vectorstore/deeplake_vectorstore.py 88.88% <ø> (-0.27%) ⬇️
...lake/core/vectorstore/test_deeplake_vectorstore.py 59.66% <14.28%> (-0.77%) ⬇️
.../core/vectorstore/vector_search/dataset/dataset.py 95.78% <75.00%> (-0.45%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nvoxland nvoxland changed the title Batched query support Set VectorStore.search embedding argument type Aug 15, 2023
@nvoxland nvoxland merged commit 453d86a into main Aug 15, 2023
5 of 9 checks passed
@nvoxland nvoxland deleted the Batched_query_support branch August 15, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants