Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle closed I/O error in spinner #2520

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Handle closed I/O error in spinner #2520

merged 1 commit into from
Aug 15, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • It seems stderr is closed by pytest, and spinner thread errors out when trying to perform operations on it.
  • It should be safe to ignore this.

Things to be aware of

Things to worry about

Additional Context

@FayazRahman FayazRahman marked this pull request as draft August 8, 2023 09:19
@FayazRahman FayazRahman marked this pull request as ready for review August 14, 2023 10:36
@FayazRahman FayazRahman merged commit 4a01722 into main Aug 15, 2023
2 of 5 checks passed
@FayazRahman FayazRahman deleted the fy_spinner branch August 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adolkhan adolkhan adolkhan approved these changes

@nvoxland nvoxland nvoxland approved these changes

@xiaohanhuang xiaohanhuang Awaiting requested review from xiaohanhuang

@sounakr sounakr Awaiting requested review from sounakr

@levongh levongh Awaiting requested review from levongh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FayazRahman @nvoxland @adolkhan