Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if samples are the same in Indra vs Python #2516

Closed
wants to merge 2 commits into from
Closed

Conversation

ProgerDav
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (7f48f19) 84.88% compared to head (513ac18) 84.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2516      +/-   ##
==========================================
+ Coverage   84.88%   84.90%   +0.01%     
==========================================
  Files         328      328              
  Lines       38847    38850       +3     
==========================================
+ Hits        32977    32984       +7     
+ Misses       5870     5866       -4     
Flag Coverage Δ
unittests 84.90% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lake/core/vectorstore/test_deeplake_vectorstore.py 60.04% <0.00%> (-0.39%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@ProgerDav ProgerDav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant as underlying issue seems to have been found already.

@ProgerDav ProgerDav closed this Aug 5, 2023
@ProgerDav ProgerDav deleted the dg_trig_test branch August 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant