Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse indra dataset in query. #2513

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Reuse indra dataset in query. #2513

merged 5 commits into from
Aug 4, 2023

Conversation

khustup
Copy link
Contributor

@khustup khustup commented Aug 1, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

If the indra dataset is already exists we are trying to use already in memory indra dataset instead of creating new one

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (1c6db8a) 84.90% compared to head (8bdbae9) 84.90%.
Report is 1 commits behind head on main.

❗ Current head 8bdbae9 differs from pull request most recent head a2ddfc7. Consider uploading reports for the commit a2ddfc7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2513   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         328      328           
  Lines       38837    38848   +11     
=======================================
+ Hits        32973    32983   +10     
- Misses       5864     5865    +1     
Flag Coverage Δ
unittests 84.90% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/vectorstore/deeplake_vectorstore.py 89.15% <ø> (ø)
deeplake/core/dataset/dataset.py 91.71% <83.33%> (-0.03%) ⬇️
...lake/core/vectorstore/test_deeplake_vectorstore.py 60.42% <100.00%> (+0.25%) ⬆️
deeplake/enterprise/libdeeplake_query.py 64.51% <100.00%> (+2.44%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levongh levongh merged commit 7f48f19 into main Aug 4, 2023
@levongh levongh deleted the fix/query-reuse-indra branch August 4, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants