Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2372] do not accept empty tokens for private datasets #2507

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Jul 28, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

if the dataset's token is empty or None and the dataset is not a public one then we need to get the token from the client side to normally process and create dataloader object from it

Things to be aware of

Things to worry about

Additional Context

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.01% 🎉

Comparison is base (fe1a109) 84.90% compared to head (9fed361) 84.92%.
Report is 6 commits behind head on main.

❗ Current head 9fed361 differs from pull request most recent head 360198f. Consider uploading reports for the commit 360198f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
+ Coverage   84.90%   84.92%   +0.01%     
==========================================
  Files         328      328              
  Lines       38830    38820      -10     
==========================================
- Hits        32970    32968       -2     
+ Misses       5860     5852       -8     
Flag Coverage Δ
unittests 84.92% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lake/core/vectorstore/test_deeplake_vectorstore.py 59.91% <ø> (+0.12%) ⬆️
deeplake/core/tests/test_deeplake_indra_dataset.py 12.30% <33.33%> (+1.05%) ⬆️
deeplake/enterprise/convert_to_libdeeplake.py 50.00% <33.33%> (+5.14%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levongh levongh changed the title do not accept empty tokens for private datasets [AL-2372] do not accept empty tokens for private datasets Jul 30, 2023
@tatevikh tatevikh requested a review from sounakr July 31, 2023 15:58
levongh and others added 2 commits August 1, 2023 10:23
@levongh levongh merged commit 638b487 into main Aug 1, 2023
@levongh levongh deleted the exception_if_token_is_empty branch August 1, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants