Improved test execution #2482
Merged
Improved test execution #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farizrahman4u
approved these changes
Jul 17, 2023
FayazRahman
approved these changes
Jul 18, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
- Coverage 84.81% 83.90% -0.91%
==========================================
Files 330 224 -106
Lines 39474 24374 -15100
==========================================
- Hits 33481 20452 -13029
+ Misses 5993 3922 -2071
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
artgish
force-pushed
the
identify_slow_tests
branch
from
199a14d
to
efbb7b9
Compare
artgish
added
quick-tests
artgish
force-pushed
the
identify_slow_tests
branch
from
233c26d
to
4f5b50a
Compare
nvoxland
force-pushed
the
identify_slow_tests
branch
2 times, most recently
from
b800333
to
c4b8bff
Compare
levongh
reviewed
Aug 28, 2023
- Introduced flaky test marker - Fixed failing tests - Disable locks in tests - Disabled tqdm.interval-monitor in tests - Improved test github action - Introduced caching around posixpath.relpath() as it caused a surprising slowdown in tests - Ensure `test_dataset` is always in a consistent location - Moved some tests to use local datastore vs. hub-cloud
nvoxland
force-pushed
the
identify_slow_tests
branch
from
eea5817
to
6faa6ff
Compare
# Conflicts: # deeplake/core/seed.py
|
Kudos, SonarCloud Quality Gate passed! |
adolkhan
approved these changes
Aug 31, 2023
levongh
approved these changes
Sep 1, 2023
# Conflicts: # deeplake/core/vectorstore/test_deeplake_vectorstore.py # deeplake/enterprise/test_pytorch.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Changes
Making tests pass consistently and easier to troubleshoot when they don't.
pytest.mark.slowto make it easier to run the full suite consistently by skipping the slow tests. The fast tests run first on the build system for quicker feedback on failurespytest.mark.flakyand moved them to a separate build stepI didn't do a lot with the overall code performance, but I addressed these two issues:
test_datasetto be recreated/re-downloaded in several locations, so I made it always be created in the repo rootThere was also a couple previously-failing (and maybe newly failing?) tests I fixed.
Other PRs that go along with this: