Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gunicorn >= 19.0 support in gunicorn worker #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niligulmohar
Copy link

With this change the socket.socket API is used directly for sockets that
don't have any version of the gunicorn.sock.BaseSocket address
attribute, which is necessary since gunicorn 19.0 and this commit:

benoitc/gunicorn@9a83d71

With this change the socket.socket API is used directly for sockets that
don't have any version of the gunicorn.sock.BaseSocket address
attribute, which is necessary since gunicorn 19.0 and this commit:

benoitc/gunicorn@9a83d71
@niligulmohar
Copy link
Author

... and now i found #211 😓

Well, i prefer this solution, since it will support any socket.socket like object through duck typing instead of just the gevent.socket.socket variety. Do you have an opinion @jares777?

@jares777
Copy link

Yes I agree with you. I am glad to see that there is life again in this package.
I have been using it in production for last one year without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants