Fix 1981 is synthesized fix in loop #1983
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can see things like library logs, or any additional logging we might add to help debug a test case.
… GitHub job running time limit I’m trying to understand the reason that the upload artifacts step is hung here [1], and I’m wondering if it’s because the job execution limit had already been reached by my script. [1] https://github.com/ably/ably-cocoa/runs/5979297645?check_suite_focus=true
To help with understanding issue described in b774222.
I’m hoping this will reduce the upload time (more by reducing the number of files than the size).
This lets us choose the length and parallelism of our test runs.
…p-iOS17 # Conflicts: # .github/workflows/check-pod.yaml # .github/workflows/integration-test-iOS16_2.yaml # .github/workflows/integration-test.yaml
… an initial substring of its id" from RTP2b1.
…ed-fix-in-loop # Conflicts: # .github/workflows/docs.yml # .github/workflows/examples.yaml # .github/workflows/integration-test.yaml
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results in a loop - https://test-observability.herokuapp.com/repos/ably/ably-cocoa/uploads?branches%5B%5D=fix%2F1981-isSynthesized-fix-in-loop
Interesting upload - a lot of timeouts and failures with "Error 50004 - Service Unavailable (server at capacity limit)" or similar errors.