-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message interactions #1785
Draft
AndyTWF
wants to merge
8
commits into
main
Choose a base branch
from
message-interactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Message interactions #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the ably-java implementation of the same class, checks the message extras and a few other fields on the message to check that they match the user-provided filter. This class will be used as part of a message filterer to implement filtered message interactions.
Rather than manage filtered listeners directly in the channel class, which makes it awkward to test in isolation, the ARTFilteredListeners class separates out this behaviour. Also adds a filtered listener class that applies the filter before calling the listener.
This change implements the message interactions specification RTL22 for the ARTRealtimeChannel class. Includes a method to subscribe a listener with a filter as well as one to remove listeners based on the filter they have associated with them (if at all).
AndyTWF
requested review from
lawrence-forooghian and
maratal
and removed request for
lawrence-forooghian
July 24, 2023 07:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the "subscription" aspect of the message interactions feature.
JIRA links:
Spec points:
It contains the following changes:
ClientOptions
is instantiated in the library.subscribe
andunsubscribe
overloads to RealtimeChannel to provide the necessary methods for users to use the new filters, as per RTL22.To test:
ARTMessageFilter
and specify whatever filters you'd like to useFilters that can be tested:
Other implementations for reference:
ably/ably-js#1003
ably/ably-java#966