Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car #2 is floating above the road #4 #5

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

OrionStar25
Copy link

Copy link
Owner

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@OrionStar25 Still floating xD

@OrionStar25
Copy link
Author

screenshot from 2018-01-21 20-21-31

It shows fine in mine :/

css/main.css Outdated
@@ -40,13 +40,13 @@ body
{
position:absolute;
left:10000px;
bottom:135px;
bottom:500px;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrionStar25 That's cuz you are defining it in pixels, see how the original car's bottom property has been specified.

#car
 {
 	position:fixed;
 	left:20%;
 	bottom:17%;
 	height:6vw;
 	width:14vw;
 	background:url('../images/car.png');
 	background-size: contain;
 	background-repeat: no-repeat;
 	z-index: 100;
 
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants