Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel TSC module #79

Merged
merged 14 commits into from
Apr 6, 2023
Merged

Add parallel TSC module #79

merged 14 commits into from
Apr 6, 2023

Conversation

lgarrison
Copy link
Member

This adds a multi-threaded TSC module under abacusnbody.analysis.tsc, as a first step to improving the performance of the power spectrum module (#70). The basic algorithm is to partition the particles into stripes and parallelize the TSC over stripes. I get really good performance, over 500 M particles/sec with 32 cores on a small grid (but this mostly depends on the memory bandwidth of the platform).

I also moved the power spectrum and 2PCF files out of the hod package and into abacusnbody.analysis.

I added linting using ruff, so there's a number of small stylistic changes to some of the files that were moved (because ruff runs against any files that were touched in the commit). The most common non-trivial issue flagged by ruff was unused variables; I commented those out in the source code in case they were there for some (future) reason.

@boryanah, @SandyYuan for visibility

@lgarrison lgarrison requested a review from boryanah March 22, 2023 19:27
@lgarrison
Copy link
Member Author

@boryanah do you want to take a look at this? I wrote an overview of the new TSC module here: https://abacusutils--79.org.readthedocs.build/en/79/tutorials/analysis/tsc.html . Let me know if you have any suggestions before I merge. I'll look at the power spectrum part of the code after this.

@lgarrison lgarrison merged commit 1477873 into master Apr 6, 2023
@lgarrison lgarrison deleted the tsc-opt branch April 6, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant