-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallel TSC module #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@boryanah do you want to take a look at this? I wrote an overview of the new TSC module here: https://abacusutils--79.org.readthedocs.build/en/79/tutorials/analysis/tsc.html . Let me know if you have any suggestions before I merge. I'll look at the power spectrum part of the code after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a multi-threaded TSC module under
abacusnbody.analysis.tsc
, as a first step to improving the performance of the power spectrum module (#70). The basic algorithm is to partition the particles into stripes and parallelize the TSC over stripes. I get really good performance, over 500 M particles/sec with 32 cores on a small grid (but this mostly depends on the memory bandwidth of the platform).I also moved the power spectrum and 2PCF files out of the
hod
package and intoabacusnbody.analysis
.I added linting using ruff, so there's a number of small stylistic changes to some of the files that were moved (because ruff runs against any files that were touched in the commit). The most common non-trivial issue flagged by ruff was unused variables; I commented those out in the source code in case they were there for some (future) reason.
@boryanah, @SandyYuan for visibility