Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for v1.4 #104

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Preparing for v1.4 #104

merged 5 commits into from
Aug 4, 2023

Conversation

lgarrison
Copy link
Member

@boryanah @SandyYuan I think we are just about ready to make a pip release. Is there anything else either of you wanted to put in?

We can call this version 1.4. We've added a lot so we could consider bumping to 2.0, but usually that would be done to indicate we broke compatibility with earlier releases, which I don't think we've done (but let me know if you think we have).

Can you check CHANGES.rst to make sure it's up to date? The full set of changes is here, although it's a very big diff: v1.3.0...main. It's probably best to just read through the changelog and look at closed PRs to see if we missed any big items.

One outstanding issue that may break future releases is that we'll want to unify the TSC and CIC interfaces. But it's probably not worth holding up this release to fix that.

Preparing for v1.4.0
@lgarrison
Copy link
Member Author

Looks like classy compilation is broken now that Cython 3.0 has been released on pip (lesgourg/class_public#531). We can fix it in CI, but there's not much we can do for end users. But classy is hidden behind abacusutils[all], so at least it won't bother everyone.

Try to fix CI for classy
Try to fix classy build again
Trying again to fix classy
@boryanah
Copy link
Collaborator

I would like to add in my changes from the power_spec branch (I haven't pushed to it yet but will do so tomorrow) -- is it possible to "include" it as part of this PR and version release?

@lgarrison
Copy link
Member Author

Yeah, the release doesn't need to come from this PR. You can just make another PR into main. I was mostly just using this PR to fix up the changelog (and fix the classy build apparently) and asking for any last contributions.

@boryanah
Copy link
Collaborator

Ah, I see -- looks good to me!

@lgarrison
Copy link
Member Author

@boryanah I'm going to merge this just to get the CI passing again, but let me know when you've pushed your power_spec changes.

@lgarrison lgarrison merged commit 17eed1e into main Aug 4, 2023
6 checks passed
@lgarrison lgarrison deleted the prep-1.4 branch August 4, 2023 13:04
@boryanah
Copy link
Collaborator

boryanah commented Aug 8, 2023

Great -- started a new PR for CV power spectrum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants