Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ResetContext func to allow resetting initialized context #989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanstantsin-chernik
Copy link

The feature allows a context to be reset before reusing it in multiple go-routines (see the issue).

An alternative solution would be to always create a new context, which would be overkill for 99.9% of single-threaded use cases.

@joerdav
Copy link
Collaborator

joerdav commented Nov 21, 2024

My concern on this one is the unexpected effects that reseting the context could cause.

  • Children
  • Scripts
  • CSS
  • Once
  • Security Nonces

We should either mitigate these in some way with this solution, or document the possible outcomes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants