Mainページの作成 #8
Merged
Mainページの作成 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Najah7
reviewed
Mar 10, 2024
src/app/main/page.tsx
Outdated
There was a problem hiding this comment.
全体的にdivの数が気になるかもです。
コンポーネントの中に隠せるやつは隠した方がいいかも。
ex) <div className="h-max"> <UserSearchForm /> </div>
src/components/Sidebar.tsx
Outdated
There was a problem hiding this comment.
imho: Tailwindのスタイルだけ変数に入れて、コンポーネントは一行のアローで書くのもアリかも。
src/components/User.tsx
Outdated
| > | ||
| <div className="flex flex-row items-center"> | ||
| <div className="mb-2 mr-4"> | ||
| <UserIcon iconImageHash={user.iconImageHash} size={96} /> |
There was a problem hiding this comment.
こちらで対応しました！
931e080
src/components/UserList.tsx
Outdated
| import { UserData } from "../../proto/typescript/pb_out/main"; | ||
|
|
||
| // テストデータ | ||
| const users: UserData[] = [ |
There was a problem hiding this comment.
なかなか量があるので、テストデータは別ファイルに移した方がよさそう。
There was a problem hiding this comment.
こちらで対応しました！
9ca834c
src/components/UserList.tsx
Outdated
| <div className="w-1/12"> | ||
| <span | ||
| className="material-symbols-outlined" | ||
| style={{ fontSize: "96px", color: "#bfdbfe" }} |
There was a problem hiding this comment.
ここだけインラインの理由は？
また、コメントで補足 or 96pxを変数に格納することで意図がわかるようにした方がいいかも。
There was a problem hiding this comment.
ここで対応しました！
4b8fc1b
| } | ||
|
|
||
| const CareerPreview = (props: Props) => { | ||
| const { user } = props; |
There was a problem hiding this comment.
FLY（どっちでもOKです。）
ただの共有っす、こっちの書き方もアリかもです。
const CareerPreview = ({ user }: Props) => {...}
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRで実装される機能
今後実装する機能
UI
2024-03-10.14.41.02.mov
PRで修正される機能
レビューをお願いしたいポイント