Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize synonym type definition for PLURAL #173

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Oct 12, 2023

We're working towards standardizing synonym type definitions across the OBO Foundry. This involved getting OMO terms for several common synonym type definitions. More information in OBOFoundry/OBOFoundry.github.io#2450.

In this PR, the ad hoc definition in ZFA for PLURAL synonyms is replaced with the standard synonym type definition OMO:0003004 for plural syonyms

CC @ybradford @cerivs

We're working towards standardizing synonym type definitions across the OBO Foundry. This involved getting OMO terms for several common synonym type definitions. More information in OBOFoundry/OBOFoundry.github.io#2450.

In this PR, the ad hoc definition in ZFA for PLURAL synonyms is replaced with the standard synonym type definition OMO:0003004 for plural syonyms
@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 31, 2023

Emailed about this on october 31, 2023

@cerivs
Copy link
Collaborator

cerivs commented Nov 21, 2023

This change breaks the editor so will not merge.

@cerivs cerivs self-assigned this Nov 21, 2023
@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 21, 2023

@cerivs in f09d190 I added what I think was a missing type definition. Can you see if this fixes the editor?

@cerivs
Copy link
Collaborator

cerivs commented Nov 21, 2023

Looks like your pull isn't replacing synonyms that are "RELATED PLURAL" with "RELATED OMO:0003004"

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 21, 2023

Looks like your pull isn't replacing synonyms that are "RELATED PLURAL" with "RELATED OMO:0003004"

updated in 0c5aff7. Thanks for being patient

@cerivs
Copy link
Collaborator

cerivs commented Nov 21, 2023

Yay! Is working now.

@cerivs cerivs merged commit 5d5bd88 into ZFIN:master Nov 21, 2023
1 check passed
@cthoyt cthoyt deleted the update-synonyms branch November 21, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants