Remove glob imports

tests/test_app.py

@@ -1,18 +1,30 @@
 #!/usr/bin/env python3
 
-import subprocess
 import copy
 import json
+import os
+import subprocess
 import sys
-import toml
 
-from lib.lib_package_linter import *
+import toml
+from lib.lib_package_linter import (
+    Error,
+    Info,
+    Success,
+    TestSuite,
+    Warning,
+    config_panel_v1_schema,
+    file_exists,
+    test,
+    tests_reports,
+    validate_schema,
+)
 from lib.print import _print, is_json_output
 
+from tests.test_catalog import AppCatalog
+from tests.test_configurations import Configurations
 from tests.test_manifest import Manifest
 from tests.test_scripts import Script
-from tests.test_configurations import Configurations
-from tests.test_catalog import AppCatalog
 
 scriptnames = ["_common.sh", "install", "remove", "upgrade", "backup", "restore"]
 

tests/test_catalog.py

@@ -1,12 +1,23 @@
 #!/usr/bin/env python3
 
-import toml
 import json
+import os
+import subprocess
 import sys
+import time
 from datetime import datetime
-import subprocess
 
-from lib.lib_package_linter import *
+import toml
+from lib.lib_package_linter import (
+    Critical,
+    Error,
+    Info,
+    Success,
+    TestSuite,
+    Warning,
+    test,
+    urlopen,
+)
 from lib.print import _print
 
 ########################################

tests/test_configurations.py

@@ -1,11 +1,21 @@
 #!/usr/bin/env python3
 
-import re
 import json
-import toml
+import os
+import re
 import subprocess
 
-from lib.lib_package_linter import *
+import toml
+from lib.lib_package_linter import (
+    Error,
+    Info,
+    TestSuite,
+    Warning,
+    file_exists,
+    test,
+    tests_v1_schema,
+    validate_schema,
+)
 from lib.print import _print
 
 
@@ -384,7 +394,8 @@ def find_path_traversal_issue(nginxconf):
 
             do_path_traversal_check = False
             try:
-                import pyparsing, six
+                import pyparsing
+                import six
 
                 do_path_traversal_check = True
             except Exception:

tests/test_manifest.py

@@ -1,14 +1,24 @@
 #!/usr/bin/env python3
 
-import json
 import copy
+import json
 import os
-import sys
-import toml
 import re
+import sys
 
-from lib.lib_package_linter import *
-
+import toml
+from lib.lib_package_linter import (
+    Critical,
+    Error,
+    Info,
+    TestSuite,
+    Warning,
+    c,
+    manifest_v2_schema,
+    spdx_licenses,
+    test,
+    validate_schema,
+)
 
 # Only packaging v2 is supported on the linter now ... But someday™ according The Prophecy™, packaging v3 will be a thing
 app_packaging_format = 2

tests/test_scripts.py

@@ -1,11 +1,21 @@
 #!/usr/bin/env python3
 
-import shlex
+import os
 import re
-import subprocess
+import shlex
 import statistics
+import subprocess
 
-from lib.lib_package_linter import *
+from lib.lib_package_linter import (
+    Critical,
+    Error,
+    Info,
+    TestSuite,
+    Warning,
+    file_exists,
+    report_warning_not_reliable,
+    test,
+)
 from lib.print import _print