devtool: remove stale import. #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
argparse and sys also appear to be unused. glob should be moved to the top of the list. |
|
@johntoomey will update accordingly. |
* `yaml` is imported but not used. This may cause issues as `yaml` is not a standard library module. * Remove trailing newlines.
|
@peteut thanks for the patch I will cherry pick and run through the CI. |
mhatle
pushed a commit
that referenced
this pull request
Jul 15, 2024
Based on github Pull Request #61. 1. `yaml` is imported but not used. This may cause issues as `yaml` is not a standard library module. 2. Remove trailing newlines. Signed-off-by: Alain Péteut <[email protected]> Update commit message and added PR number in commit message. Also update import list order. Signed-off-by: Sandeep Gundlupet Raju <[email protected]> Signed-off-by: Mark Hatle <[email protected]>
msreeram-xilinx
pushed a commit
that referenced
this pull request
Oct 30, 2024
Based on github Pull Request #61. 1. `yaml` is imported but not used. This may cause issues as `yaml` is not a standard library module. 2. Remove trailing newlines. Signed-off-by: Alain Péteut <[email protected]> Update commit message and added PR number in commit message. Also update import list order. Signed-off-by: Sandeep Gundlupet Raju <[email protected]> Signed-off-by: Mark Hatle <[email protected]>
mhatle
pushed a commit
that referenced
this pull request
Nov 25, 2024
Based on github Pull Request #61. 1. `yaml` is imported but not used. This may cause issues as `yaml` is not a standard library module. 2. Remove trailing newlines. Signed-off-by: Alain Péteut <[email protected]> Update commit message and added PR number in commit message. Also update import list order. Signed-off-by: Sandeep Gundlupet Raju <[email protected]> Signed-off-by: Mark Hatle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yamlis imported but not used. This may cause issues asyamlis not a standard library module.