Support of transposed convolutions through pixel padding #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rtlsim and cppsim
…model for comparison
… transformation. Validating all tests including stitched IP rtlsim.
…tion to push scalar Mul nodes past ConvTranspose nodes, with associated unit test
…, as depthwise deconvolution is not yet supported
…full conversion to HLS layers
…n. Adding support for FMPadding_Pixel in SetFolding
…inn-fork into feature/pixelpadding
auphelia
reviewed
Jan 2, 2024
auphelia
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Thanks @hleblevec ,
I've cleaned up a few things and adjusted the new test cases. Since the Brevitas version was changed as well, there is a few additional tests that will need to succeed before this will be merged.
|
Thanks @auphelia for taking the time to review this and sorry if there were things I forgot. I don't know which tests you are talking about but don't hesitate to ask if you need help running them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradually adding classes and functions to support the "pixel padding" implementation of transposed convolutions.