-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create phys nets from logical #770
Open
haydenc-amd
wants to merge
23
commits into
Xilinx:master
Choose a base branch
from
haydenc-amd:createPhysNetsFromLogical
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hayden Cook <[email protected]>
…tlist Signed-off-by: Hayden Cook <[email protected]>
Signed-off-by: Hayden Cook <[email protected]>
clavin-xlnx
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a test for these methods. Also, could you please remove the white space changes that appear to be unrelated?
haydenc-amd
force-pushed
the
createPhysNetsFromLogical
branch
from
August 31, 2023 22:13
31e782c
to
20bdfa6
Compare
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Co-authored-by: Chris Lavin <[email protected]> Signed-off-by: haydenc-amd <[email protected]>
Signed-off-by: Hayden Cook <[email protected]>
Signed-off-by: Hayden Cook <[email protected]>
Signed-off-by: Hayden Cook <[email protected]>
haydenc-amd
force-pushed
the
createPhysNetsFromLogical
branch
from
August 31, 2023 22:15
20bdfa6
to
6b65825
Compare
Signed-off-by: Chris Lavin <[email protected]>
clavin-xlnx
reviewed
Jan 16, 2024
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.