Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a bunch of gates from the lab #520
base: develop
Are you sure you want to change the base?
Adding a bunch of gates from the lab #520
Changes from 30 commits
8950aeb
3b4dbfa
b66efa2
c923193
50917c8
bdecc2f
ed7a7bd
318f2d3
8f2c2d3
feabd56
624430c
f3331b6
2ab72f0
d68c34c
b288bd1
db65a92
2794e6b
e6bb856
ab62f2e
eb0ec72
264d318
fe9b982
a68cd95
646b297
81dcf81
2cd56cc
8708a5d
5a14cdb
5d5b097
a7e6353
04201c7
2745e1d
8e5b8c7
0af0a16
a86232f
0bcfb79
ffc8614
034e760
f40de7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you override the symplectic property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess so.. I will take a look at Ggate to see how it's done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no, I think it is characterized by other parameters (here it is just
s
). So, I believe we don't want to have it as a property.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is g the same as s? should we use the same letter if they are the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are the same thing. I will make this change