Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typos #53

wants to merge 2 commits into from

Conversation

apetenchea
Copy link

@apetenchea apetenchea commented May 17, 2024 •
edited
Loading

While reading the documentation, I stumbled across the following typos:

  • xtheadsync/sync_is.adoc: incomplete synopsis
  • xtheadmemidx/lbuia.adoc: rs register should be rd in the example
  • xtheadmemidx/ldib.adoc: mnemonic shows lwib instead of ldib

@CLAassistant
Copy link

CLAassistant commented May 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cmuellner
cmuellner approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@apetenchea
Copy link
Author

apetenchea commented May 29, 2024 •
edited
Loading

Thanks @cmuellner for the review!
I figured this is already the best place for suggesting another small fix on the ldib mnemonic, so I added another commit: 5db5d28

cmuellner
cmuellner approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmuellner cmuellner cmuellner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apetenchea @CLAassistant @cmuellner