Invalid compile result confuses IDE

[vbar]

Consider the hook exporting an extra function:

#include "hookapi.h"

void t()
{
    TRACESTR("starter.c: Called.");
}

int64_t hook(uint32_t reserved ) {
    t();
    accept (0,0,0); 

    _g(1,1);   // every hook needs to import guard function and use it at least once
    return 0;
}

Language Server (correctly) reports hooks-entry-points-neg error on it, which (unfortunately) doesn't prevent compilation (see #126). Compiler backend reports success (which is also incorrect and probably should be a bug against https://github.com/XRPLF/hook-cleaner-c ) but produces invalid Wasm, leading the Hooks Builder to show a link to deploy, although the deploy tab still says "You haven't compiled any files yet, compile files on develop view." Hooks Builder should report when it cannot parse received Wasm.

[muzam1l]

Compiler backend reports success

It's bug inside compile function in ide, will fix it soon.

[muzam1l]

probably should be a bug against https://github.com/XRPLF/hook-cleaner-c

Maybe, because it produces invalid wasm with success result, but we can fix it on our end too.

[vbar]

probably should be a bug against https://github.com/XRPLF/hook-cleaner-c

Maybe, because it produces invalid wasm with success result, but we can fix it on our end too.

yes, belt and suspenders :-)