Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile to Wasm button should be disabled when Language Server reports errors #126

Open
vbar opened this issue Mar 9, 2022 · 2 comments

Comments

@vbar
Copy link
Collaborator

vbar commented Mar 9, 2022

As the workbook says, "When user is ready and there are no errors, Compile action is readily available."

This is a bit tricky in that the Language Server might crash - it would probably make sense to also enable the Compile button when the Language Server is unavailable.

@muzam1l
Copy link
Collaborator

muzam1l commented Jul 21, 2022

it would probably make sense to also enable the Compile button when the Language Server is unavailable.

That seems to be the case right now, compile bottom is always available.

Compile to Wasm button should be disabled when Language Server reports errors.

It doesn't seem to be an issue as compiling with errors in file, summarizes those errors in logs.

@vbar
Copy link
Collaborator Author

vbar commented Jul 21, 2022

Compile to Wasm button should be disabled when Language Server reports errors.

It doesn't seem to be an issue as compiling with errors in file, summarizes those errors in logs.

Not always - see e.g. #254 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants