feat: Healthcheck endpoint #1751
Open
+82
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1751 +/- ##
===========================================
- Coverage 71.71% 71.71% -0.01%
===========================================
Files 292 295 +3
Lines 12487 12652 +165
Branches 6359 6473 +114
===========================================
+ Hits 8955 9073 +118
- Misses 1848 1871 +23
- Partials 1684 1708 +24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
godexsoft
commented
Nov 23, 2024
| @@ -49,10 +48,8 @@ resolve(std::string const& ip, std::string const& port) | |||
| { | |||
| web::Resolver resolver; | |||
|
|
|||
| if (auto const results = resolver.resolve(ip, port); not results.empty()) { | |||
| std::cout << "resolved ip: '" << results.at(0) << '\n'; | |||
godexsoft
commented
Nov 23, 2024
| @@ -178,6 +186,16 @@ ClioApplication::run(bool const useNgWebServer) | |||
| } | |||
| ); | |||
|
|
|||
| httpServer->onGet( | |||
There was a problem hiding this comment.
This will be a nuisance when merging back into release/2.3.0
kuznetsss
reviewed
Nov 25, 2024
| @@ -178,6 +186,16 @@ ClioApplication::run(bool const useNgWebServer) | |||
| } | |||
| ); | |||
|
|
|||
| httpServer->onGet( | |||
| "/health", | |||
There was a problem hiding this comment.
Maybe /ping? Or /healthcheck?
There was a problem hiding this comment.
Maybe /ping will be confusing. Because we have ping API
| @@ -58,7 +59,7 @@ using tcp = boost::asio::ip::tcp; | |||
|
|
|||
| namespace { | |||
|
|
|||
| std::string | |||
| std::pair<boost::beast::http::status, std::string> | |||
There was a problem hiding this comment.
Maybe a structure would be better?
cindyyan317
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement a simple endpoint for system healthcheck.