-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: New error handling Deprecated Classes and Functions #1729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the valid and invalid examples correct here?
I see different parameter names in the examples, but the description is about values.
In this case, it should be string values that are used, not variable names:
Valid:
bloginfo( 'url' );
$tagline = get_bloginfo( 'description' );
Invalid:
bloginfo( 'siteurl' );
$home_url = get_bloginfo( 'home' );
These examples also then include indicators that it applies to bloginfo()
and get_bloginfo()
.
Please also see the other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes please.
FYI: @fkeijzer and me have sat down together at WordCamp Nijmegen today to review this. The changes I've pushed now in the second commit have been made by us together. @GaryJones Would you like to do one last look over ? (and merge if deemed ok) |
Related to #1722