Update URL for ucrtbase2019 to remove hardcoded archive.org prefix #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the
archive.orgprefix is automatically added in the download function (on second try), meaning there shouldn't be a need for hardcoding thearchive.orgURL prefix.I've tested a quick game installation using the downloaded EXE from the Microsoft servers & everything seemed to run fine.
Note
Theoretically there could be another reason for the permanent URL prefix - e.g. the setup file on the Microsoft servers changed at some point, no longer containing a working
ucrtbase.dll. Play-testing Tarkov didn't reveal any issues with the dll..edit: since the file is checked via
sha256sum- this shouldn't be a concern either.