Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inject macro to support containers #17

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

ncipollo
Copy link
Contributor

@ncipollo ncipollo commented Oct 15, 2024

Updates the generated code to take in the injecting container. This will allow this to function correctly with child containers (eventually).

Copy link
Contributor

@jrosen081 jrosen081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good just 2 comments

Sources/WhoopDIKit/WhoopDI.swift Outdated Show resolved Hide resolved
@@ -49,7 +49,11 @@ class NilSingletonModule: DependencyModule {

protocol Dependency { }

class DependencyA: Dependency { }
class DependencyA: Dependency, Equatable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't make this a struct and get that for free?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 - a good one

@ncipollo ncipollo merged commit b511d50 into main Oct 16, 2024
1 check passed
@ncipollo ncipollo deleted the ncipollo/macro-container branch October 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants