Refactor WhoopDI to leverage container internally #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrosen081
approved these changes
Oct 15, 2024
| @@ -1,29 +1,19 @@ | |||
| import Foundation | |||
| public final class WhoopDI: DependencyRegister { | |||
| nonisolated(unsafe) private static let serviceDict = ServiceDictionary<DependencyDefinition>() | |||
| nonisolated(unsafe) private static var localServiceDict: ServiceDictionary<DependencyDefinition>? = nil | |||
| nonisolated(unsafe) private static let appContainer = Container() | |||
There was a problem hiding this comment.
this is not related to the thread-safety stuff we had talked about before right? Since this is still the reason for the crashes I believe
There was a problem hiding this comment.
Correct - I'm just getting some infra work out of the way so I don't need to fix the thread safety issue twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.