Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(plugin): apply git hooks against existing codebase #13

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Sep 24, 2024

In this PR, I basically ran pre-commit run -a and made some manual cleanup to comply with rules introduced with git hooks.

Some questions @kannes:

  • is there a specific reason to use a different case for naming certain modules: userInterface, interface_handler.py, Bookmarks...
  • have the tests already been played? They look like those generated by pb (plugin builder), right? If so, we should remove them, no?
  • what's the point of darkedetect subpkg?

@kannes
Copy link
Contributor

kannes commented Sep 26, 2024

  • is there a specific reason to use a different case for naming certain modules: userInterface, interface_handler.py, Bookmarks...

Nope, feel welcome to harmonize all that.

  • have the tests already been played? They look like those generated by pb (plugin builder), right? If so, we should remove them, no?

Agreed, there is nothing of use in that directory. If I'd set up tests, I would use pytest.

  • what's the point of darkedetect subpkg?

I think the original developer wanted an automatic switch to a dark UI theme. I'd say throw it all away :)

@Guts
Copy link
Collaborator Author

Guts commented Sep 26, 2024

Thanks for your answers.

I'll dot those changes in future PRs. You can review and (hopefully) merge this one.

@kannes
Copy link
Contributor

kannes commented Sep 26, 2024

👍 looks good!

@kannes kannes merged commit 4207040 into WhereGroup:main Sep 26, 2024
@Guts Guts deleted the refacto/apply-git-hooks branch September 26, 2024 14:57
@Guts Guts added the enhancement New feature or request label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants