Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rebuilding empty placeholder libraries #550

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

abrown
Copy link
Collaborator

@abrown abrown commented Nov 19, 2024

Previously, these were rebuilt each time as a part of the phone dummy_libs target. This change only rebuilds them if they don't exist.

Previously, these were rebuilt each time as a part of the phone
`dummy_libs` target. This change only rebuilds them if they don't exist.
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sunfishcode sunfishcode merged commit 913e58e into WebAssembly:main Nov 20, 2024
8 checks passed
@abrown abrown deleted the reorganize-dummy-libs branch November 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants