feat: bump to axum 0.7 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
approved these changes
Apr 8, 2024
| @@ -37,7 +37,7 @@ profiler = ["alloc/profiler"] | |||
| rate_limit = ["dep:rate_limit"] | |||
|
|
|||
| [workspace.dependencies] | |||
| aws-sdk-s3 = "1.13" | |||
| aws-sdk-s3 = "1.21.0" | |||
There was a problem hiding this comment.
Can we remove the patch version number and use only 1.21?
There was a problem hiding this comment.
Rust dependency resolution allows higher patch versions to be compatible with lower ones, which I think is your concern.
This is setting a minimum version which was copy/pasted from crates.io and so should be OK to do. Setting to a lower version would be lying about which versions you've tested with as Cargo.lock is initially set to the latest version. More details here
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps to the latest axum version and related dependencies. Involves some minor breaking changes. Necessary for the rennovatebot PR on Notify Server: WalletConnect/notify-server#467
How Has This Been Tested?
Existing tests and in WalletConnect/notify-server#467
Due Diligence