feat: EIP-1271 #301
feat: EIP-1271 #301
Conversation
chris13524
force-pushed
the
feat/eip1271
branch
from
e214f83
to
5bdb867
Compare
chris13524
requested review from
Elyniss,
geekbrother,
arein,
xav and
nopestack
and removed request for
geekbrother
| @@ -7,7 +7,8 @@ allow = [ | |||
| "Unlicense", | |||
| "BSD-3-Clause", | |||
| "0BSD", | |||
| "ISC" | |||
| "ISC", | |||
| "CC0-1.0" | |||
| ] | |||
There was a problem hiding this comment.
Seems like a dependency changed and this license is actually being used. A few weeks ago the checker had me remove it because it was unused, but now it wanted me to add back. Not sure what happened.
This license is a public domain license so we can allow it.
I have not tested EIP-1271 in Notify Server, just in WalletConnectRust. The changes here are extremely minimal so don't think testing was necessary. EOAs still work (according to tests), so if smart accounts upport doesn't work we can fix in follow-up. |
| pub struct MockGetRpcUrl; | ||
| impl GetRpcUrl for MockGetRpcUrl { | ||
| fn get_rpc_url(&self, _: String) -> Option<Url> { | ||
| None |
There was a problem hiding this comment.
Does this work in tests as it's always None?
There was a problem hiding this comment.
EIP-1271 is not tested by Notify Server tests (however it should be in the future). So since this function will never be called, it's ok to return None.
chris13524
force-pushed
the
feat/eip1271
branch
from
6f52c79
to
31b8900
Compare
Description
Resolves #145
Several improvements should be made in another iteration, but these are not urgent: #345
Remaining work:
How Has This Been Tested?
Automated tests
Due Diligence