Run authenticate in get_authentication_errors
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where logged in users could not authenticate requests with their OAuth credentials. * Removes hooking of `authenticate` on `determin_current_user` (which doesn't run or runst too late when the user presents login cookies) * Instead, authenticate directly in `rest_authentication_errors` callback
|
any option on this @rmccue? it fixes the logged in user issue. |
|
I think this might have got fixed in here : 662c9f8 All OAuth tests seem to be working for me now. My cobbled-together test script is here : https://gist.github.com/kosso/71c957e30a40116e5f98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where logged in users could not authenticate requests with their OAuth credentials.
authenticateondetermin_current_user(which doesn't run or runst too late when the user presents login cookies)rest_authentication_errorscallback