Springboot jdbc #55

qiaoxibj · 2016-06-21T08:48:13Z

Check in Springboot code with:

Springboot Jersey
Springboot Security
Springboot JDBC
UI enhancement

This change is

and update the description

katheris · 2016-06-21T10:09:59Z

Review status: 0 of 74 files reviewed at latest revision, 1 unresolved discussion.

build.gradle, line 28 [r2] (raw file):

      }
      dependencies {
          classpath 'net.wasdev.wlp.gradle.plugins:liberty-gradle-plugin:1.1-SNAPSHOT'

What is the reason for changing to version 1.1-SNAPSHOT rather than staying with 1.0.

Comments from Reviewable

katheris · 2016-06-21T10:10:21Z

Reviewed 1 of 65 files at r2.
Review status: 1 of 74 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

katheris · 2016-06-21T10:15:54Z

Review status: 1 of 74 files reviewed at latest revision, 1 unresolved discussion.

build.gradle, line 28 [r2] (raw file):

Previously, katheris (Katherine Stanley) wrote…

What is the reason for changing to version 1.1-SNAPSHOT rather than staying with 1.0.

My mistake, you are moving back to 1.0, which indicates that your original one isn't matching up to what is in master.

Comments from Reviewable

katheris · 2016-06-21T10:51:06Z

Reviewed 8 of 65 files at r2.
Review status: 9 of 74 files reviewed at latest revision, 6 unresolved discussions.

README.md, line 25 [r2] (raw file):

## Spring Boot with Spring MVC
This project demonstrate a "hello world" web site with Spring technology and run on IBM WebSphere Liberty Server

Should be: This project demonstrates a "hello world" web application with Spring technology, running on an IBM WebSphere Liberty Server.

README.md, line 28 [r2] (raw file):

Learn more about IBM WebSphere Liberty, visit <a href="https://developer.ibm.com/wasdev/">https://developer.ibm.com/wasdev/</a>

Inside the application project containing two classes:

Inside the application project there are two classes:

README.md, line 33 [r2] (raw file):

Inside the wlpcfg project there is the <code>it.springboot.web.HelloControllerTest</code> that will test the Spring MVC endpoint to ensure it is working.
For the complete feature documentation, see the <a href="http://spring.io/guides/gs/serving-web-content">Serving Web Content with Spring MVC</a>

This should link to documentation about how to write spring applications that run on a Liberty server. See issue #56.

liberty-starter-application/src/main/resources/services.json, line 6 [r2] (raw file):

            "id" : "rest",
            "name" : "REST",
            "description" : "REST technology allows to create a simple JAX-RS application by using Liberty jaxrs-2.0 feature. \nNotice that REST technology cannot co-exist with Spring Boot with Jersey technology.",

Grammar needs adjusting.

liberty-starter-wlpcfg/servers/StarterServer/resources/security/.gitignore, line 2 [r2] (raw file):

/ltpa.keys
/key.jks

Need to revert this file.

Comments from Reviewable

katheris · 2016-06-21T10:56:35Z

Reviewed 4 of 65 files at r2.
Review status: 13 of 74 files reviewed at latest revision, 17 unresolved discussions.

starter-microservice-springboot-jdbc/repository/0.0.1/compile-pom.xml, line 14 [r2] (raw file):

      <license>
          <name>The Apache Software License, Version 2.0</name>
          <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

Should be tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/compile-pom.xml, line 21 [r2] (raw file):

  <scm>
      <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
      <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

Should be tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/compile-pom.xml, line 22 [r2] (raw file):

      <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
      <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
      <url>[email protected]:WASdev/tool.artisan.core.git</url>

Should be tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/provided-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/provided-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/provided-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/provided-pom.xml, line 22 [r2] (raw file):

        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
        <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/runtime-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/runtime-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/runtime-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-jdbc/repository/0.0.1/runtime-pom.xml, line 30 [r2] (raw file):

            <artifactId>server-snippet</artifactId>
            <type>xml</type>
            <version>0.0.1</version>

Should be updated to 0.0.2

Comments from Reviewable

katheris · 2016-06-21T11:03:18Z

Reviewed 7 of 65 files at r2.
Review status: 19 of 74 files reviewed at latest revision, 18 unresolved discussions.

starter-microservice-springboot-jdbc/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/jdbc/Customer.java, line 1 [r2] (raw file):

package application.springboot.jdbc;

Missing copyright statement

Comments from Reviewable

katheris · 2016-06-21T11:05:13Z

Reviewed 1 of 65 files at r2.
Review status: 20 of 74 files reviewed at latest revision, 19 unresolved discussions.

starter-microservice-springboot-jdbc/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/jdbc/JDBCController.java, line 39 [r2] (raw file):

      try {
          String result = "<b>Welcome to Springboot JDBC running on Liberty!</b><br><br";
          result += "<b>Creating tables:</b><br><br>";

We should have tests for this to prove it is working.

Comments from Reviewable

katheris · 2016-06-21T11:07:05Z

Reviewed 4 of 65 files at r2.
Review status: 24 of 74 files reviewed at latest revision, 20 unresolved discussions.

starter-microservice-springboot-jdbc/src/main/webapp/WEB-INF/classes/description.html, line 18 [r2] (raw file):

<div>
  <h2>Spring Boot with JDBC</h2>
  <p>This project demonstrate how to accessing relational data with Spring technology and run on IBM WebSphere Liberty Server</p>

This project demonstrates how to access relational data with Spring technology running on an IBM WebSphere Liberty server.

Comments from Reviewable

katheris · 2016-06-21T13:25:38Z

Reviewed 1 of 65 files at r2.
Review status: 25 of 74 files reviewed at latest revision, 21 unresolved discussions.

starter-microservice-springboot-jdbc/src/test/java/com/ibm/liberty/starter/service/springboot/api/v1/it/TestApplication.java, line 87 [r2] (raw file):

      assertNotNull("No response from API for sample", sample);
      assertNotNull("Expected locations", sample.getLocations());
      assertEquals("No files were expected for sample", 4, sample.getLocations().length);

Should say 4 files were expected for sample.

Comments from Reviewable

katheris · 2016-06-21T13:27:14Z

Reviewed 1 of 47 files at r1, 2 of 65 files at r2.
Review status: 28 of 74 files reviewed at latest revision, 25 unresolved discussions.

starter-microservice-springboot-jersey/repository/0.0.1/compile-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/compile-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/compile-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/compile-pom.xml, line 22 [r2] (raw file):

        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
        <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

Comments from Reviewable

katheris · 2016-06-21T13:27:40Z

Reviewed 1 of 65 files at r2.
Review status: 29 of 74 files reviewed at latest revision, 29 unresolved discussions.

starter-microservice-springboot-jersey/repository/0.0.1/provided-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/provided-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/provided-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/provided-pom.xml, line 22 [r2] (raw file):

        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
        <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

Comments from Reviewable

katheris · 2016-06-21T13:28:08Z

Reviewed 1 of 47 files at r1.
Review status: 30 of 74 files reviewed at latest revision, 34 unresolved discussions.

starter-microservice-springboot-jersey/repository/0.0.1/runtime-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/runtime-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/runtime-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/runtime-pom.xml, line 22 [r2] (raw file):

        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
        <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

starter-microservice-springboot-jersey/repository/0.0.1/runtime-pom.xml, line 30 [r2] (raw file):

            <artifactId>server-snippet</artifactId>
            <type>xml</type>
            <version>0.0.1</version>

Should be updated to version 0.0.2.

Comments from Reviewable

katheris · 2016-06-21T13:30:45Z

Reviewed 3 of 47 files at r1.
Review status: 33 of 74 files reviewed at latest revision, 35 unresolved discussions.

starter-microservice-springboot-jersey/src/main/java/com/ibm/liberty/starter/service/springboot/jersey/api/v1/ProviderEndpoint.java, line 40 [r2] (raw file):

public class ProviderEndpoint {

    private static final String DEPENDENCY_URL = "http://localhost:9082/springboot/artifacts/net/wasdev/wlp/starters/springboot/jersey";

This string is not being used.

Comments from Reviewable

katheris · 2016-06-21T13:32:12Z

Reviewed 2 of 47 files at r1, 1 of 65 files at r2.
Review status: 36 of 74 files reviewed at latest revision, 37 unresolved discussions.

starter-microservice-springboot-jdbc/src/main/java/com/ibm/liberty/starter/service/springboot/api/v1/ProviderEndpoint.java, line 40 [r2] (raw file):

public class ProviderEndpoint {

    private static final String DEPENDENCY_URL = "http://localhost:9082/springboot/artifacts/net/wasdev/wlp/starters/springboot/jdbc";

This string is not being used.

starter-microservice-springboot-jdbc/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/Application.java, line 1 [r2] (raw file):

package application.springboot;

Missing apache license

Comments from Reviewable

katheris · 2016-06-21T13:32:27Z

Review status: 36 of 74 files reviewed at latest revision, 38 unresolved discussions.

starter-microservice-springboot-jersey/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/Application.java, line 1 [r2] (raw file):

package application.springboot;

Missing Apache license

Comments from Reviewable

katheris · 2016-06-21T13:50:12Z

Reviewed 1 of 47 files at r1.
Review status: 37 of 74 files reviewed at latest revision, 39 unresolved discussions.

starter-microservice-springboot-jersey/src/main/webapp/WEB-INF/classes/description.html, line 18 [r2] (raw file):

<div>
  <h2>Spring Boot with Jersey</h2>
  <p>This project demonstrate creating a "hello world" RESTful web service with Spring technology and run on IBM WebSphere Liberty Server</p>

This project demonstrated creating a "hello world" RESTful web service with Spring technology, running on an IBM WebSphere Liberty server.

Comments from Reviewable

katheris · 2016-06-21T13:50:44Z

Reviewed 1 of 47 files at r1, 1 of 65 files at r2.
Review status: 39 of 74 files reviewed at latest revision, 40 unresolved discussions.

starter-microservice-springboot-jersey/src/test/java/com/ibm/liberty/starter/service/springboot/jersey/api/v1/it/TestApplication.java, line 87 [r2] (raw file):

      assertNotNull("No response from API for sample", sample);
      assertNotNull("Expected locations", sample.getLocations());
      assertEquals("No files were expected for sample", 4, sample.getLocations().length);

Should say expects 4 sample files

Comments from Reviewable

katheris · 2016-06-21T13:51:09Z

Reviewed 3 of 65 files at r2.
Review status: 42 of 74 files reviewed at latest revision, 40 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T13:51:23Z

Review status: 42 of 74 files reviewed at latest revision, 43 unresolved discussions.

starter-microservice-springboot-security/repository/0.0.1/compile-pom.xml, line 20 [r2] (raw file):

  <scm>
      <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/compile-pom.xml, line 21 [r2] (raw file):

  <scm>
      <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
      <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/compile-pom.xml, line 22 [r2] (raw file):

      <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
      <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
      <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

Comments from Reviewable

katheris · 2016-06-21T13:52:43Z

Reviewed 1 of 65 files at r2.
Review status: 43 of 74 files reviewed at latest revision, 46 unresolved discussions.

starter-microservice-springboot-security/repository/0.0.1/provided-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/provided-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/provided-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

Comments from Reviewable

katheris · 2016-06-21T13:53:05Z

Review status: 43 of 74 files reviewed at latest revision, 47 unresolved discussions.

starter-microservice-springboot-security/repository/0.0.1/provided-pom.xml, line 25 [r2] (raw file):

    </scm>

    <repositories>

Shouldn't need this repo, can use Maven central

Comments from Reviewable

katheris · 2016-06-21T13:53:18Z

Review status: 43 of 74 files reviewed at latest revision, 48 unresolved discussions.

starter-microservice-springboot-security/repository/0.0.1/provided-pom.xml, line 22 [r2] (raw file):

        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
        <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

Comments from Reviewable

katheris · 2016-06-21T13:54:11Z

Reviewed 1 of 65 files at r2.
Review status: 44 of 74 files reviewed at latest revision, 53 unresolved discussions.

starter-microservice-springboot-security/repository/0.0.1/runtime-pom.xml, line 14 [r2] (raw file):

        <license>
            <name>The Apache Software License, Version 2.0</name>
            <url>https://raw.github.com/WASdev/tool.artisan.core/master/LICENSE</url>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/runtime-pom.xml, line 20 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/runtime-pom.xml, line 21 [r2] (raw file):

    <scm>
        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/runtime-pom.xml, line 22 [r2] (raw file):

        <connection>scm:git:[email protected]:WASdev/tool.artisan.core.git</connection>
        <developerConnection>scm:[email protected]:WASdev/tool.artisan.core.git</developerConnection>
        <url>[email protected]:WASdev/tool.artisan.core.git</url>

tool.accelerate.core

starter-microservice-springboot-security/repository/0.0.1/runtime-pom.xml, line 30 [r2] (raw file):

            <artifactId>server-snippet</artifactId>
            <type>xml</type>
            <version>0.0.1</version>

Should be 0.0.2

Comments from Reviewable

katheris · 2016-06-21T13:54:30Z

Reviewed 1 of 47 files at r1, 1 of 65 files at r2.
Review status: 46 of 74 files reviewed at latest revision, 54 unresolved discussions.

starter-microservice-springboot-security/src/main/java/com/ibm/liberty/starter/service/springboot/security/api/v1/ProviderEndpoint.java, line 40 [r2] (raw file):

public class ProviderEndpoint {

    private static final String DEPENDENCY_URL = "http://localhost:9082/springboot/artifacts/net/wasdev/wlp/starters/springbootsecurity";

This string is not used

Comments from Reviewable

katheris · 2016-06-21T13:55:16Z

Reviewed 2 of 47 files at r1, 1 of 65 files at r2.
Review status: 49 of 74 files reviewed at latest revision, 55 unresolved discussions.

starter-microservice-springboot-security/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/Application.java, line 1 [r2] (raw file):

package application.springboot;

Needs copyright notice

Comments from Reviewable

katheris · 2016-06-21T13:56:12Z

Reviewed 1 of 65 files at r2.
Review status: 50 of 74 files reviewed at latest revision, 56 unresolved discussions.

starter-microservice-springboot-security/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/security/MvcConfig.java, line 1 [r2] (raw file):

package application.springboot.security;

Needs copyright notice

Comments from Reviewable

katheris · 2016-06-21T13:56:31Z

Reviewed 1 of 65 files at r2.
Review status: 51 of 74 files reviewed at latest revision, 57 unresolved discussions.

starter-microservice-springboot-security/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/security/WebSecurityConfig.java, line 1 [r2] (raw file):

package application.springboot.security;

Needs copyright notice

Comments from Reviewable

katheris · 2016-06-21T13:58:09Z

Reviewed 1 of 65 files at r2.
Review status: 52 of 74 files reviewed at latest revision, 58 unresolved discussions.

starter-microservice-springboot-security/src/main/webapp/sample/myProject-application/src/main/resources/application.properties, line 1 [r2] (raw file):

server.contextPath=/myLibertyApp

What is this being used by? Is it necessary?

Comments from Reviewable

katheris · 2016-06-21T13:58:12Z

Reviewed 1 of 65 files at r2.
Review status: 53 of 74 files reviewed at latest revision, 58 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T13:59:44Z

Reviewed 1 of 47 files at r1.
Review status: 54 of 74 files reviewed at latest revision, 58 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T14:01:05Z

Reviewed 1 of 47 files at r1.
Review status: 55 of 74 files reviewed at latest revision, 59 unresolved discussions.

starter-microservice-springboot-security/src/main/webapp/WEB-INF/classes/description.html, line 18 [r2] (raw file):

<div>
  <h2>Spring Boot with Security</h2>
  <p>This project demonstrate creating a simple web application with resources that are protected by Spring Security and run on IBM WebSphere Liberty Server</p>

This project demonstrates creating a simple web application with resources that are protected by Spring security, running on IBM WebSphere Liberty server.

Comments from Reviewable

katheris · 2016-06-21T14:01:10Z

Reviewed 1 of 65 files at r2.
Review status: 56 of 74 files reviewed at latest revision, 59 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T14:01:23Z

Reviewed 1 of 47 files at r1.
Review status: 57 of 74 files reviewed at latest revision, 59 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T14:01:51Z

Review status: 57 of 74 files reviewed at latest revision, 60 unresolved discussions.

starter-microservice-springboot-security/src/test/java/com/ibm/liberty/starter/service/springboot/security/api/v1/it/TestApplication.java, line 87 [r2] (raw file):

      assertNotNull("No response from API for sample", sample);
      assertNotNull("Expected locations", sample.getLocations());
      assertEquals("No files were expected for sample", 8, sample.getLocations().length);

Should say 8 sample files were expected.

Comments from Reviewable

katheris · 2016-06-21T14:02:49Z

Reviewed 1 of 65 files at r2.
Review status: 58 of 74 files reviewed at latest revision, 60 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T14:04:56Z

Reviewed 1 of 65 files at r2.
Review status: 59 of 74 files reviewed at latest revision, 60 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T14:36:37Z

Review status: 59 of 74 files reviewed at latest revision, 61 unresolved discussions.

starter-microservice-springboot-web/repository/0.0.1/compile-pom.xml, line 7 [r2] (raw file):

    <groupId>net.wasdev.wlp.starters.springbootweb</groupId>
    <artifactId>compile-pom</artifactId>
    <version>0.0.1</version>

This should have the version 0.0.2-SNAPSHOT and should not result in version 0.0.1 of net.wasdev.wlp.starters.springboot being deleted

Comments from Reviewable

katheris · 2016-06-21T14:37:31Z

Reviewed 1 of 65 files at r2.
Review status: 60 of 74 files reviewed at latest revision, 62 unresolved discussions.

starter-microservice-springboot-web/repository/0.0.1/provided-pom.xml, line 5 [r2] (raw file):

    <modelVersion>4.0.0</modelVersion>

    <groupId>net.wasdev.wlp.starters.springbootweb</groupId>

Revert this change, there is already a version 0.0.2 with this change

Comments from Reviewable

katheris · 2016-06-21T14:38:10Z

Reviewed 1 of 65 files at r2.
Review status: 61 of 74 files reviewed at latest revision, 63 unresolved discussions.

starter-microservice-springboot-web/repository/0.0.1/runtime-pom.xml, line 5 [r2] (raw file):

    <modelVersion>4.0.0</modelVersion>

    <groupId>net.wasdev.wlp.starters.springbootweb</groupId>

This change should be reverted, the change has already been made in version 0.0.2.

Comments from Reviewable

katheris · 2016-06-21T14:42:36Z

Reviewed 1 of 65 files at r2.
Review status: 62 of 74 files reviewed at latest revision, 64 unresolved discussions.

starter-microservice-springboot-web/src/main/webapp/sample/myProject-application/src/main/java/application/springboot/Application.java, line 1 [r2] (raw file):

package application.springboot;

Missing copyright notice

Comments from Reviewable

katheris · 2016-06-21T14:42:40Z

Reviewed 1 of 65 files at r2.
Review status: 63 of 74 files reviewed at latest revision, 64 unresolved discussions.

Comments from Reviewable

katheris · 2016-06-21T14:43:58Z

Review status: 63 of 74 files reviewed at latest revision, 65 unresolved discussions.

starter-microservice-springboot-web/src/main/webapp/WEB-INF/classes/description.html, line 18 [r2] (raw file):

<div>
  <h2>Spring Boot with Spring MVC</h2>
  <p>This project demonstrate a "hello world" web site with Spring technology and run on IBM WebSphere Liberty Server</p>

This project demonstrates a "hello world" web application using Spring technologies and running on an IBM WebSphere Liberty server.

Comments from Reviewable

katheris · 2016-06-21T14:44:03Z

Reviewed 1 of 65 files at r2.
Review status: 64 of 74 files reviewed at latest revision, 65 unresolved discussions.

Comments from Reviewable

katheris · 2016-07-01T17:00:06Z

This will be pulled into a branch rather than accepting this pull request. I will close the request when we have the code in a branch.

qiaoxibj and others added 13 commits April 18, 2016 13:11

Create new Jersey project

5adaf4f

Update with Jersey code

1b0af18

Update with Spring Boot Jersey sample code

eb94ea8

SpringBoot security

eed5146

Update with Springboot Security

0ab347f

Optimize code to make muti srpingboot technology work together better

6cf5f7b

and update the description

Update description

35e1561

Create new Springboot JDBC project

95d5c74

Add Springboot JDBC and fix some problem for Jersy and security

27a0172

Update README.md file for description

fa10331

ignore security keys from project

ce5f515

Remove security keys

52ec977

Commit with Jordan's UI enhancement: mark conflict features

a2606b5

hughesj mentioned this pull request Jun 21, 2016

Ensure all tabs are converted to spaces ... #58

Open

Springboot jdbc #55

Are you sure you want to change the base?

Springboot jdbc #55

Conversation

qiaoxibj commented Jun 21, 2016 • edited by ebullient Loading

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jun 21, 2016

katheris commented Jul 1, 2016

qiaoxibj commented Jun 21, 2016 •

edited by ebullient

Loading