-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS-5813]Fix nurl not triggered issue #8
base: master
Are you sure you want to change the base?
Conversation
* Address Banner and MREC ad display issue. This commit will update the show ad for Banner/Mrec to be called after the ad finishes downloading the assets. Also updates the finish display ad to be called on destroy. IOS-5559 IOS-5560
About how to test this issue: For non-bidding ads:
From Charles logs config-max-test.zip For Bidding ads: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good - still having issues with cocoapods and getting max repos set up for testing, so I'll hold on approval and let others confirm change works as expected.
@YueVungle the fix u did works only for water fall. the issue is with sdk.
|
025c13f
to
a64f1ad
Compare
Before loading an ad, the MAX Adapter will check if the ad is cached. If the ad is cached, the MAX Adapter will not call the load ad API. This will cause the issue that the nurl is not be triggered. This issue happens in both bidding and waterfall ads.
nurl must be triggered after calling load ad API explicitly.
IOS-5813