Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component override #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

component override #143

wants to merge 1 commit into from

Conversation

SachaG
Copy link
Contributor

@SachaG SachaG commented Sep 30, 2022

No description provided.

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vulcan-docs ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 0:37AM (UTC)
vulcan-npm ❌ Failed (Inspect) Sep 30, 2022 at 0:37AM (UTC)

@eric-burel
Copy link
Collaborator

eric-burel commented Sep 30, 2022

Not needed imo, this is equivalent to what your are trying to achieve

// eg if Loading allows to override its Button locally
const Loading = ({components}: { components: Partial<Pick<VulcanCoreComponents, "Button">>) => {
  const VulcanComponents = useVulcanComponents()
  const Components = {...components, ...VulcanComponents }
  return (<Components.Button>Loading...</Components.Button>)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants