Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type check for text area #172

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #170

I'm not sure that we should do a type check if a field has a different type not compatible with the editor

@vitPinchuk vitPinchuk self-assigned this Nov 20, 2024
@vitPinchuk vitPinchuk marked this pull request as ready for review November 20, 2024 14:48
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (5e95161) to head (c8a696f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         164      164           
  Lines        2643     2644    +1     
  Branches      587      609   +22     
=======================================
+ Hits         2637     2638    +1     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 21, 2024
@mikhail-vl mikhail-vl added this to the Table 1.8.0 milestone Nov 21, 2024
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 3922b74 into main Nov 22, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/null-string-value-text-area branch November 22, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BUG : error when editing a string field in text area mode
4 participants