Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boolean type and Switch editor #171

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Add boolean type and Switch editor #171

merged 8 commits into from
Nov 22, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #144

@vitPinchuk vitPinchuk self-assigned this Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (487f9a4) to head (14d21d0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         163      164    +1     
  Lines        2629     2643   +14     
  Branches      584      587    +3     
=======================================
+ Hits         2623     2637   +14     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 20, 2024
@mikhail-vl mikhail-vl added this to the Table 1.8.0 milestone Nov 20, 2024
@vitPinchuk
Copy link
Contributor Author

@asimonok @mikhail-vl ready for review

asimonok
asimonok approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 5e95161 into main Nov 22, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/checkbox-type branch November 22, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Status: Done
Milestone
Table 1.8.0
Development

Successfully merging this pull request may close these issues.

POPUP or CheckBox table editing
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl