Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom value to editable select field #165

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Add custom value to editable select field #165

merged 9 commits into from
Nov 21, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #162

@vitPinchuk vitPinchuk self-assigned this Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.77%. Comparing base (3f0bb76) to head (822c3b3).

Files with missing lines Patch % Lines
src/module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   99.76%   99.77%           
=======================================
  Files         163      163           
  Lines        2608     2617    +9     
  Branches      591      579   -12     
=======================================
+ Hits         2602     2611    +9     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 18, 2024
@mikhail-vl mikhail-vl added this to the Table 1.8.0 milestone Nov 18, 2024
asimonok
asimonok approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 614cbd6 into main Nov 21, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/custom-select-value branch November 21, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Table 1.8.0
Development

Successfully merging this pull request may close these issues.

Add custom value to editable select field
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl