Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter options to match exactly #160

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Update filter options to match exactly #160

merged 5 commits into from
Nov 14, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #128

@vitPinchuk vitPinchuk self-assigned this Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (b8fa21d) to head (e329182).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         162      162           
  Lines        2545     2547    +2     
  Branches      573      573           
=======================================
+ Hits         2539     2541    +2     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 14, 2024
@mikhail-vl mikhail-vl added this to the Table 1.7.0 milestone Nov 14, 2024
src/utils/table.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Filter options works as "=" Update filter options to match exactly Nov 14, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit b6d4f90 into main Nov 14, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/filter-list branch November 14, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Filter options are like and not =
4 participants