Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to hide table header #157

Merged
merged 9 commits into from
Nov 17, 2024
Merged

Add option to hide table header #157

merged 9 commits into from
Nov 17, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #139

@vitPinchuk vitPinchuk self-assigned this Nov 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (e4f95dd) to head (3c3f4cc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         163      163           
  Lines        2580     2592   +12     
  Branches      577      588   +11     
=======================================
+ Hits         2574     2586   +12     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 11, 2024
@mikhail-vl mikhail-vl added this to the Table 1.7.0 milestone Nov 11, 2024
asimonok
asimonok requested changes Nov 11, 2024
View reviewed changes
src/utils/test.ts Outdated Show resolved Hide resolved
asimonok
asimonok approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Add show/hide header for table Add option to hide table header Nov 14, 2024
asimonok
asimonok approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit b6bda16 into main Nov 17, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/show-hide-header branch November 17, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Table 1.7.0
Development

Successfully merging this pull request may close these issues.

Option to hide headers
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl