Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add openXR support #291

Draft
wants to merge 9 commits into
base: Multiloader-1.20.4
Choose a base branch
from
Draft

[WIP] Add openXR support #291

wants to merge 9 commits into from

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Aug 1, 2024

Add OpenXR support
TODO

  • Test on all different OpenXR platforms
  • Figure out key binding system
  • Verify all functionality

Add first attempt OpenXR support
TODO
- Test on all different OpenXR platforms
- Figure out key binding system
- Verify all functionality

Co-authored-by: The Judge <[email protected]>
Co-authored-by: fayer3 <[email protected]>
@ferriarnus ferriarnus changed the title [WIP] Add openXR support (#230) [WIP] Add openXR support Aug 1, 2024
Copy link

@thejudge156 thejudge156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenXR Conformance issues,


session = new XrSession(sessionPtr.get(0), instance);

XrSessionBeginInfo sessionBeginInfo = XrSessionBeginInfo.calloc(stack);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results in XR_ERROR_SESSION_NOT_READY as you did not wait for the runtime signal.


error = XR10.xrBeginSession(session, sessionBeginInfo);
logError(error, "xrBeginSession", "");
this.isActive = true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to after line 698.

fayer3 and others added 5 commits November 21, 2024 02:07
Co-authored-by: ferriarnus <[email protected]>
Co-authored-by: The Judge <[email protected]>
* Fix Conformance Issues

Co-Authored-By: ferriarnus <[email protected]>
Co-Authored-By: The Judge <[email protected]>

* Create DeviceCompat for QuestCraft

Co-Authored-By: The Judge <[email protected]>

* fix lwjgl openxr version

* Use Custom OpenXR Library

* Switch to OpenXR 1.0.40

* Log Device Platform

* Remove Discord from repo list

---------

Co-authored-by: ferriarnus <[email protected]>
Co-authored-by: The Judge <[email protected]>
Co-authored-by: fayer3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants