Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python example syntax #92

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

simbilod
Copy link
Contributor

@simbilod simbilod commented Aug 22, 2024

Many examples, run out of the box*, give errors of type:

Traceback (most recent call last):
  File "/home/simbil/Github/ViennaPS/examples/GDSReader/GDSReader.py", line 27, in <module>
    plane = vls.lsDomain(bounds, boundaryConds, gridDelta)
            ^^^^^^^^^^^^
AttributeError: module 'viennals3d' has no attribute 'lsDomain'. Did you mean: 'Domain'?

Implementing the suggested change, as is done everywhere relevant in this PR, makes the scripts run.

*unless I set things up wrong! I followed the README of ViennaLS and ViennaPS

@tobre1
Copy link
Member

tobre1 commented Aug 22, 2024

Thank you for updating the examples!

It seems we overlooked updating some of them with the latest changes to the library.

@tobre1 tobre1 merged commit 37b5c34 into ViennaTools:master Aug 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants