-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC mariadb proto extensions #23
POC mariadb proto extensions #23
Conversation
Its a discussion on how to represent it. I'm not fixed on any particular format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions! Some comments from me, but feel free to disagree:
- Probably "Protocol Extensions" would be clearer? (Still not perfect, because one might wonder what exactly is extended)
- Have you tried to use lists? They might be more readable.
- When the column's left blank, it's not clear if there are not extensions or we don't know. Where appropriate, I'd write
None
.
sure.
Good point. I'll adjust.
Ok. I'll make that clear. For extensions I was thinking of making the following distinctions following the attribute abbreviation per connector:
It occurs to be basic protocol exposure of MySQL protocol could exist too. Like https://stackoverflow.com/questions/65136607/how-do-i-get-granular-load-data-results-from-the-golang-mysql-package/65136957#65136957 showing that there's a lack of OK packet decoding and making that available to the end user. I think this should be the same column? Is this acceptable? |
@grooverdan Very informative. I approve it. If the table bloats too much, we can move these details to a new file with a 2-way table: the horizontal axis is the list of extensions and the vertical axis is the list of connectors. |
There's a conflict in table headers, please rebase or manually change a header. |
8faa842
to
dd65f1a
Compare
dd65f1a
to
7177ebc
Compare
ready. Looks ok on my gh fork. |
Thanks @federico-razzoli |
Proof of concept. I'm looking for way of putting driver support of https://mariadb.com/kb/en/mariadb-protocol-differences-with-mysql/ mapped out.