Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC mariadb proto extensions #23

Merged

Conversation

grooverdan
Copy link
Contributor

Proof of concept. I'm looking for way of putting driver support of https://mariadb.com/kb/en/mariadb-protocol-differences-with-mysql/ mapped out.

@grooverdan
Copy link
Contributor Author

Its a discussion on how to represent it. I'm not fixed on any particular format.

Copy link
Member

@federico-razzoli federico-razzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! Some comments from me, but feel free to disagree:

  1. Probably "Protocol Extensions" would be clearer? (Still not perfect, because one might wonder what exactly is extended)
  2. Have you tried to use lists? They might be more readable.
  3. When the column's left blank, it's not clear if there are not extensions or we don't know. Where appropriate, I'd write None.

@grooverdan
Copy link
Contributor Author

Great additions! Some comments from me, but feel free to disagree:

1. Probably "Protocol Extensions" would be clearer? (Still not perfect, because one might wonder what exactly is extended)

sure.

2. Have you tried to use [lists](https://stackoverflow.com/a/19976953/9445059)? They might be more readable.

Good point. I'll adjust.

3. When the column's left blank, it's not clear if there are not extensions or we don't know. Where appropriate, I'd write `None`.

Ok. I'll make that clear.

For extensions I was thinking of making the following distinctions following the attribute abbreviation per connector:

  • version of connector including the feature, and a link to documentation/interface.
  • a Requested linking to a feature request if one has been made.
  • a N/A (not applicable) if the extension is somehow unsuitable for the connector.
  • a No if the feature request has been rejected by the upstream.
  • a Not present if investigated and found to be missing.

It occurs to be basic protocol exposure of MySQL protocol could exist too. Like https://stackoverflow.com/questions/65136607/how-do-i-get-granular-load-data-results-from-the-golang-mysql-package/65136957#65136957 showing that there's a lack of OK packet decoding and making that available to the end user. I think this should be the same column?

Is this acceptable?

@federico-razzoli
Copy link
Member

@grooverdan Very informative. I approve it. If the table bloats too much, we can move these details to a new file with a 2-way table: the horizontal axis is the list of extensions and the vertical axis is the list of connectors.

@federico-razzoli
Copy link
Member

There's a conflict in table headers, please rebase or manually change a header.

@grooverdan grooverdan force-pushed the poc_mariadb_proto_extensions branch 4 times, most recently from 8faa842 to dd65f1a Compare October 24, 2024 17:14
@grooverdan
Copy link
Contributor Author

ready. Looks ok on my gh fork.

@federico-razzoli federico-razzoli merged commit 4181a93 into Vettabase:main Oct 26, 2024
1 check passed
@grooverdan
Copy link
Contributor Author

Thanks @federico-razzoli

@grooverdan grooverdan deleted the poc_mariadb_proto_extensions branch October 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants