configure.sh: Add option to disable SELinux labeling for container volumes #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --disable-labeling to configure.sh. Passing this option passes --security-opt label=disable to the container, which disables SELinux labeling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--disable-labelingto configure.sh. Passing this option passes--security-opt label=disableto the container arguments, which disables SELinux labeling. This is something of a nuclear option compared to :z or :Z for volume binds, but far simpler and basically guaranteed to work, and for a build container the security implications hardly matter.The existing
--relabel-volumesoption which passes:Z(capital) is a little bit not-nice because it relabels the files on the host (:z, lowercase, only relabels them in the container).