Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some memory errors #114

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix some memory errors #114

merged 2 commits into from
Aug 14, 2023

Conversation

FraGag
Copy link
Contributor

@FraGag FraGag commented Aug 13, 2023

  1. Make sure S98Player::_fileHdr is zero-initialized by the constructor.
  2. Handle resampling of blocks larger than the initial sample buffer size by allocating a larger buffer when necessary. Fixes Audio buffer overflow #12.

@FraGag
s98player.cpp: zero-init _fileHdr
4598782 
Fixes "Conditional jump or move depends on uninitialised value(s)"
reported by Valgrind in S98Player::RefreshTSRates().
@FraGag
resampler: resize the sample buffer when needed
1912612 
Handle resampling of blocks larger than the initial sample buffer size
by allocating a larger buffer when necessary.

Fixes ValleyBell#12
@FraGag FraGag mentioned this pull request Aug 13, 2023
Closed
@ValleyBell ValleyBell merged commit 1912612 into ValleyBell:master Aug 14, 2023
8 checks passed
@ValleyBell
Copy link
Owner

Thanks!

@FraGag FraGag deleted the fixes branch August 14, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio buffer overflow
2 participants
@FraGag @ValleyBell