+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sevenc-nanashi
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
LGTM。
せっかくだしyargsを捨ててもいいかも、Node標準にargsパーサーがあるので： https://nodejs.org/api/util.html#utilparseargsconfig
|
typescriptがちゃんと型つけてくれるならNodeのが良い気がしますね！！ とりあえずこれはCI通ったらマージしちゃおうと思います |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
でgenerateLicense側のyargs/yargsは変わっていた一方、こっちは変わってなくてエラーになってたので修正します。
関連 Issue
ref #2361
その他
なんでlintが通ったのか若干不明