-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
選択した再生デバイスがソングでも適用されるようにする #2375
Open
X-20A
wants to merge
16
commits into
VOICEVOX:main
Choose a base branch
from
X-20A:selection-unify
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−0
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f743e45
とりあえず動く
X-20A 093c6d2
型追記
X-20A 98ca600
修正
X-20A 0697dc6
watchEffectを使用してエディタの切り替えを監視し、ショートカットキーの設定を更新
Hiroshiba 0308c3e
Merge pull request #3 from Hiroshiba/hiho-counter-pr-0697dc64
X-20A 467c5a9
Merge branch 'main' into tab-state
Hiroshiba ed3d4ab
openedEditorをundefinedで初期化し、設定スキーマを更新
Hiroshiba 8f41006
Merge pull request #4 from Hiroshiba/hiho-counter-pr-ed3d4ab6
X-20A 6f91632
微修正
X-20A e9cfec3
wip
X-20A 31aac0f
設定タイミングの変更
X-20A 8c5dfae
修正
X-20A 8ae2f63
Merge branch 'main' into selection-unify
Hiroshiba a5391e6
設定場所変更
X-20A 1f1e902
Merge branch 'selection-unify' of https://github.com/X-20A/voicevox i…
X-20A ded8c10
タイミング再調整
X-20A File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
関数をexportする形になっていますが、actionにしても良いかもです。
actionにすると
App.vue
からstore
経由でアクセスできると思います。(
App.vue
のsinging.ts
への依存を無くせると思います)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stateの操作は行わないのでvuexでやると不自然かな、という判断でした。ただ、この関数だけexportしてるのでどちらが馴染むかはなんとも分からないですね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!
確かにこの処理ではstateの操作は行われませんが、audioContextはアプリケーションの状態(グローバルな状態)に含まれるのと、関数にすると
ビューレイヤー(vueのコンポーネント)
→アプリケーションレイヤー(src/store以下の処理)
の経路が関数とactionの2つになってしまうので、vuexのactionで行うのが良いかなと思います。