Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: ConfigManagerのマイグレーション時にスナップショットテストを追加 #2357

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+253 −1
Open

Add: ConfigManagerのマイグレーション時にスナップショットテストを追加 #2357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ae518e
追加: ConfigManagerに全設定を取得するメソッドを追加し、スナップショットテストを更新
Hiroshiba Nov 16, 2024
21803d9
Merge branch 'main' into configmanagerにスナップショットテスト追加
Hiroshiba Nov 18, 2024
7ad7c5e
修正: ショートカットキーの組み合わせをMetaからCtrlに変更
Hiroshiba Nov 18, 2024
ae131a0
修正: ConfigManagerのスナップショットテストにOS判定を追加
Hiroshiba Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/backend/common/ConfigManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,12 @@ export abstract class BaseConfigManager {
this._save();
}

/** 全ての設定を取得する。テスト用。 */
public getAll(): ConfigType {
if (!this.config) throw new Error("Config is not initialized");
return this.config;
}

private _save() {
void this.lock.acquire(lockKey, async () => {
await this.save({
Expand Down
239 changes: 239 additions & 0 deletions tests/unit/backend/common/__snapshots__/configManager.spec.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion tests/unit/backend/common/configManager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pastConfigs from "./pastConfigs";
import configBugDefaultPreset1996 from "./pastConfigs/0.19.1-bug_default_preset.json";
import { BaseConfigManager } from "@/backend/common/ConfigManager";
import { configSchema } from "@/type/preload";
import { configSchema, isMac } from "@/type/preload";

const configBase = {
...configSchema.parse({}),
Expand Down Expand Up @@ -85,6 +85,13 @@ for (const [version, data] of pastConfigs) {
const configManager = new TestConfigManager();
await configManager.initialize();
expect(configManager).toBeTruthy();

// マイグレーション後のデータが正しいことをスナップショットで確認
// NOTE: Macはショートカットキーが異なるためパス
// TODO: ConfigManagerにOSを引数指定できるようにしてテストを分ける
if (!isMac) {
expect(configManager.getAll()).toMatchSnapshot();
}
});
}

Expand Down
Loading