Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: エンジン最新情報周りのリファクタリング #2346

Conversation

Hiroshiba
Copy link
Member

内容

VVPPデフォルトエンジンのためのリファクタリングです。
使いやすいように型を整理しつつ、用語を整えています。

ついでにnode環境で動かしてたテストを普通の環境でも動くようにしてみました。

関連 Issue

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner November 6, 2024 18:53
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Nov 6, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:def9ba7

Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たぶん大丈夫だと思うのでマージします!

@Hiroshiba Hiroshiba merged commit 4689cf8 into VOICEVOX:main Nov 7, 2024
10 checks passed
@Hiroshiba Hiroshiba deleted the src/domain/defaultEngine/latetDefaultEngine.tsのリファクタリング branch November 7, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant